[lvm-devel] [PATCH 0/4] pvcreate & detection of foreign signatures

[Petr Rockai]

Hi,

Milan Broz <mbroz at redhat.com> writes:
> After the third report of broken LUKS after pvcreate (just this week...)
> I added LUKS detection to lvm. But the current code is messy and in fact
> it wipes superblocks without asking by default.
>
> This is attempt to change that to something more user friendly.
Looks OK to me. I am trusting you on the LUKS detection bit, the rest

Reviewed-By: Petr Rockai <prockai at redhat.com>

> Milan Broz (4):
>   Change the pvcreate swap/md logic
>   Remove assumption that --ye must be used only in --force mode
>   Fix file open leak in swap signature detection
>   Detect LUKS signature in pvcreate
>
>  lib/Makefile.in         |    1 +
>  lib/device/dev-luks.c   |   43 ++++++++++++++++++++++++++++
>  lib/device/dev-swap.c   |   12 +++----
>  lib/device/device.h     |    1 +
>  lib/metadata/metadata.c |   71 +++++++++++++++++++++++++----------------------
>  tools/pvremove.c        |    5 ---
>  tools/toollib.c         |    5 ---
>  7 files changed, 88 insertions(+), 50 deletions(-)
>  create mode 100644 lib/device/dev-luks.c