[lvm-devel] [PATCH 10/23] Fix memory leak of dev_filter on error path
Milan Broz
mbroz at redhat.com
Tue Dec 21 17:21:47 UTC 2010
On 12/21/2010 04:41 PM, Zdenek Kabelac wrote:
> @@ -352,5 +357,8 @@ struct dev_filter *persistent_filter_create(struct dev_filter *real,
> dm_hash_destroy(pf->devices);
> dm_free(pf);
> dm_free(f);
> +
> + fail:
> + real->destroy(real);
> return NULL;
> }
Why not move it to the caller instead - the same like previous two?
if (!(f4 = persistent_filter_create(f3, dev_cache))) {
log_error("Failed to create persistent device filter");
+ f3->destroy(f3);
return 0;
}
Milan
More information about the lvm-devel
mailing list