[lvm-devel] [PATCH 18/23] Return PERCENT_INVALID for error case

Milan Broz mbroz at redhat.com
Tue Dec 21 17:47:30 UTC 2010


On 12/21/2010 04:41 PM, Zdenek Kabelac wrote:
> +	if (!lv_mirror_percent(lv->vg->cmd, (struct logical_volume *) lv,
> +			   0, &perc, NULL))
> +		perc = PERCENT_INVALID;
> +	return perc;

dunno, these functions returns 0 if (!activation()) and if lv is not activated
 is the PERCENT_INVALID (-1) correct value here?

But it is apparent bug, it returns undefined value in API now.

Milan




More information about the lvm-devel mailing list