[lvm-devel] [PATCH 1/2] Always query device by uuid only.
Petr Rockai
prockai at redhat.com
Wed Feb 24 15:39:07 UTC 2010
Milan Broz <mbroz at redhat.com> writes:
> --- a/lib/activate/dev_manager.c
> +++ b/lib/activate/dev_manager.c
> @@ -123,12 +123,14 @@ static int _info_run(const char *name, const char *dlid, struct dm_info *info,
> {
> int r = 0;
> struct dm_task *dmt;
> - int dmtask;
>
> - dmtask = mknodes ? DM_DEVICE_MKNODES : DM_DEVICE_INFO;
> -
> - if (!(dmt = _setup_task(name, dlid, 0, dmtask, major, minor)))
> - return_0;
> + if (mknodes) {
> + if (!(dmt = _setup_task(name, dlid, 0, DM_DEVICE_MKNODES, major, minor)))
> + return_0;
> + } else {
> + if (!(dmt = _setup_task(NULL, dlid, 0, DM_DEVICE_INFO, major, minor)))
> + return_0;
> + }
Can we instead have
if (!(dmt = _setup_task(mknodes ? name : NULL, dlid, 0, dmtask, major, minor)))
return_0;
please?
Otherwise, ACK.
More information about the lvm-devel
mailing list