[lvm-devel] [PATCH 10 of 10] LVM: rework lvconvert_mirrorsuil
Takahiro Yasui
tyasui at redhat.com
Mon Mar 8 05:54:35 UTC 2010
Jonathan Brassow wrote:
> +static int _lvconvert_mirrors_aux(struct cmd_context *cmd,
> + struct logical_volume *lv,
> + struct lvconvert_params *lp,
> + struct dm_list *operable_pvs,
> + uint32_t new_mimage_count,
> + uint32_t new_log_count,
> + int allocation_failures_ok)
> +{
> + uint32_t region_size;
> + struct lv_segment *seg;
...
> + /* Insert a temporary layer for syncing,
> + * only if the original lv is using disk log. */
> + if (seg->log_lv && !_insert_lvconvert_layer(cmd, lv)) {
> + log_error("Failed to insert resync layer");
> + return 0;
> + }
"seg" seems to be used uninitialized here.
> +static int _lvconvert_mirrors_orig(struct cmd_context *cmd,
> + struct logical_volume *lv,
> + struct lvconvert_params *lp)
> +{
This function is not used anywhere...
Thanks,
Taka
More information about the lvm-devel
mailing list