[lvm-devel] [PATCH 09/29] Remove check for lv is NULL
Zdenek Kabelac
zkabelac at redhat.com
Thu Nov 25 10:55:13 UTC 2010
'lv' is deferenced in the begining of the function so any check
later is not helpful.
Parameters for dev_manager_transien() will be marked as nonnull.
Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
---
lib/activate/dev_manager.c | 15 +++++++--------
1 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/lib/activate/dev_manager.c b/lib/activate/dev_manager.c
index cbb5378..cbd55f2 100644
--- a/lib/activate/dev_manager.c
+++ b/lib/activate/dev_manager.c
@@ -614,14 +614,13 @@ int dev_manager_transient(struct dev_manager *dm, struct logical_volume *lv)
do {
next = dm_get_next_target(dmt, next, &start, &length, &type,
¶ms);
- if (lv) {
- if (!(segh = dm_list_next(&lv->segments, segh))) {
- log_error("Number of segments in active LV %s "
- "does not match metadata", lv->name);
- goto out;
- }
- seg = dm_list_item(segh, struct lv_segment);
+
+ if (!(segh = dm_list_next(&lv->segments, segh))) {
+ log_error("Number of segments in active LV %s "
+ "does not match metadata", lv->name);
+ goto out;
}
+ seg = dm_list_item(segh, struct lv_segment);
if (!type || !params)
continue;
@@ -632,7 +631,7 @@ int dev_manager_transient(struct dev_manager *dm, struct logical_volume *lv)
} while (next);
- if (lv && (segh = dm_list_next(&lv->segments, segh))) {
+ if (segh = dm_list_next(&lv->segments, segh)) {
log_error("Number of segments in active LV %s does not "
"match metadata", lv->name);
goto out;
--
1.7.3.2
More information about the lvm-devel
mailing list