[lvm-devel] [PATCH 10/29] Add some backtrace - Attention please
Zdenek Kabelac
zkabelac at redhat.com
Thu Nov 25 10:55:14 UTC 2010
ATTENTION
It is a bit unclear what should happen on error path.
My idea:
- skip to the next node if the set_name() fails.
- print the backtrace for all error cases.
Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
---
libdm/ioctl/libdm-iface.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/libdm/ioctl/libdm-iface.c b/libdm/ioctl/libdm-iface.c
index 8c0115a..147eec2 100644
--- a/libdm/ioctl/libdm-iface.c
+++ b/libdm/ioctl/libdm-iface.c
@@ -1594,8 +1594,12 @@ static int _process_mapper_dir(struct dm_task *dmt)
!strcmp(dirent->d_name, "..") ||
!strcmp(dirent->d_name, "control"))
continue;
- dm_task_set_name(dmt, dirent->d_name);
- dm_task_run(dmt);
+ if (!dm_task_set_name(dmt, dirent->d_name)) {
+ stack;
+ continue; /* try next name */
+ }
+ if (!dm_task_run(dmt))
+ stack; /* keep going */
}
if (closedir(d))
--
1.7.3.2
More information about the lvm-devel
mailing list