[lvm-devel] [PATCH 24/29] Test for str_list_add
Zdenek Kabelac
zkabelac at redhat.com
Thu Nov 25 10:55:28 UTC 2010
Check for success and report error on failure case.
Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
---
lib/format_pool/import_export.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/format_pool/import_export.c b/lib/format_pool/import_export.c
index 07f67fd..7884247 100644
--- a/lib/format_pool/import_export.c
+++ b/lib/format_pool/import_export.c
@@ -206,7 +206,10 @@ static int _add_stripe_seg(struct dm_pool *mem,
return_0;
/* add the subpool type to the segment tag list */
- str_list_add(mem, &seg->tags, _cvt_sptype(usp->type));
+ if (!str_list_add(mem, &seg->tags, _cvt_sptype(usp->type))) {
+ log_error("Allocation failed for str_list.");
+ return 0;
+ }
dm_list_add(&lv->segments, &seg->list);
@@ -240,7 +243,10 @@ static int _add_linear_seg(struct dm_pool *mem,
}
/* add the subpool type to the segment tag list */
- str_list_add(mem, &seg->tags, _cvt_sptype(usp->type));
+ if (!str_list_add(mem, &seg->tags, _cvt_sptype(usp->type))) {
+ log_error("Allocation failed for str_list.");
+ return 0;
+ }
if (!set_lv_segment_area_pv(seg, 0, usp->devs[j].pv, 0))
return_0;
--
1.7.3.2
More information about the lvm-devel
mailing list