[lvm-devel] [PATCH] Refactor handling of percent values (towards BZ 654441)

Petr Rockai prockai at redhat.com
Thu Nov 25 13:53:12 UTC 2010


Hi again,

Petr Rockai <prockai at redhat.com> writes:
> the attached patch changes over the percent handling in the code: it
> folds all percent values into a single fixed-point value, instead of a
> floating point and an enum. This simplifies existing code (no need to
> pass around extra variable/parameter), while also making it possible to
> expose the percent attributes through the lvm2app API as a single
> integral value (this is BZ 654441).

and now an amended patch, taking Alasdair's IRC feedback into account. I
have moved the implementation aside to a separate unit, and added a
comment explaining how the percent_t type works.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: percent-refactor.diff
Type: text/x-diff
Size: 36005 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20101125/d5653007/attachment.bin>
-------------- next part --------------

Yours,
   Petr.


More information about the lvm-devel mailing list