[lvm-devel] [PATCH 04/29] Reset vg pointer after release
Petr Rockai
prockai at redhat.com
Thu Nov 25 17:26:40 UTC 2010
Zdenek Kabelac <zkabelac at redhat.com> writes:
> Set vg to NULL after releasing it as the following memlock() test may
> lead to goto for the second call of vg_release() with the same vg pointer.
Ack.
> Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
> ---
> lib/metadata/metadata.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c
> index 780b806..743d633 100644
> --- a/lib/metadata/metadata.c
> +++ b/lib/metadata/metadata.c
> @@ -3117,6 +3117,7 @@ static struct volume_group *_vg_read_by_vgid(struct cmd_context *cmd,
> return vg;
> }
> vg_release(vg);
> + vg = NULL; /* reset so memlock goto out is safe */
> }
>
> /* Mustn't scan if memory locked: ensure cache gets pre-populated! */
More information about the lvm-devel
mailing list