[lvm-devel] [PATCH 17/29] Optimize second call to strchr with same parameters
Alasdair G Kergon
agk at redhat.com
Mon Nov 29 20:50:27 UTC 2010
On Thu, Nov 25, 2010 at 11:55:21AM +0100, Zdenek Kabelac wrote:
> Add tempory char* to keep result of strchr call.
> Make also static analysis happier as lv_name is now tested for nonnull.
As you know, I don't accept 'make static analysis happier' as a valid reason
for making changes:) File bugs against the static analyser instead if it's
giving false positives.
So I'll ack that for the optimisation reason only.
Alasdair
More information about the lvm-devel
mailing list