[lvm-devel] [PATCH 25/29] Check for unlink result

Alasdair G Kergon agk at redhat.com
Mon Nov 29 21:50:42 UTC 2010


On Thu, Nov 25, 2010 at 11:55:29AM +0100, Zdenek Kabelac wrote:
> Even if we intentionally wish to silently ignore any error from
> unlink in this place - it might be still good idea to put at least
> a debug message to get the reason for failure.

Don't see why not.
Ack.
 
> Test makes static analyzer happier about checked unlink result.

It's a project standard that all return values should be checked
(or explicitly discarded with a cast to void).
 
Alasdair




More information about the lvm-devel mailing list