[lvm-devel] [PATCH 06/30] Ensure we always have origin defined
Zdenek Kabelac
zkabelac at redhat.com
Mon Oct 25 08:24:13 UTC 2010
clang Logic error Dereference of null pointer
Ensure the code path could not use origin == NULL because of internal
error in code.
Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
---
tools/lvcreate.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tools/lvcreate.c b/tools/lvcreate.c
index de5b59c..a9e3c2d 100644
--- a/tools/lvcreate.c
+++ b/tools/lvcreate.c
@@ -179,6 +179,10 @@ static int _update_extents_params(struct volume_group *vg,
lp->origin);
return 0;
}
+ if (!origin) {
+ log_error(INTERNAL_ERROR "Couldn't find origin volume.");
+ return 0;
+ }
lp->extents = lp->extents * origin->le_count / 100;
break;
case PERCENT_NONE:
--
1.7.3.1
More information about the lvm-devel
mailing list