[lvm-devel] [PATCH 02/30] Use dm_pool_grow_object embeded strlen for 0 delta

ejt at redhat.com ejt at redhat.com
Mon Oct 25 09:56:50 UTC 2010


At Mon, 25 Oct 2010 10:24:09 +0200,
Zdenek Kabelac wrote:
> 
> Use internal strlen for 0
> 
> Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>

Ack, but I don't think this improves the readablility of the code.  The problem is the extra semantics of zero as the third arg to dm_pool_grow_object() (probably my bad).  Maybe introduce a new pool method dm_pool_grow_string(struct dm_pool *p, const char *str) ?




More information about the lvm-devel mailing list