[lvm-devel] [PATCH 16/30] Fix void* pointer arithmetic

Zdenek Kabelac zkabelac at redhat.com
Mon Oct 25 11:17:05 UTC 2010


Dne 25.10.2010 12:20, ejt at redhat.com napsal(a):
> At Mon, 25 Oct 2010 10:24:23 +0200,
> Zdenek Kabelac wrote:
>>
>>
>> Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
> 
> Nack.  No explanation.  eg, Are we deprecating the void pointer arithmetic gcc extension?

void* arithmetic is IMHO bad practice and we should avoid it's usage.
char* clearly defines 1byte - I'd prefer to use standard C whenever we can.
(And gcc can show this as warning - so why not fixing it)

Zdenek




More information about the lvm-devel mailing list