[lvm-devel] [PATCH 5/5] Check for NULL pointer
Zdenek Kabelac
zkabelac at redhat.com
Tue Oct 26 12:59:26 UTC 2010
clangs is happier and check for non NULL options value.
Report internal error in this case.
Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
---
tools/reporter.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tools/reporter.c b/tools/reporter.c
index f39d23f..24a27ba 100644
--- a/tools/reporter.c
+++ b/tools/reporter.c
@@ -324,6 +324,10 @@ static int _report(struct cmd_context *cmd, int argc, char **argv,
return EINVALID_CMD_LINE;
}
if (*opts == '+') {
+ if (!options) {
+ log_error(INTERNAL_ERROR "Missing options.");
+ return EINVALID_CMD_LINE;
+ }
if (!(str = dm_pool_alloc(cmd->mem,
strlen(options) + strlen(opts) + 1))) {
log_error("options string allocation failed");
--
1.7.3.2
More information about the lvm-devel
mailing list