[lvm-devel] [PATCH 1 of 4] LVM: cleanup 1
Zdenek Kabelac
zkabelac at redhat.com
Tue Jan 11 10:26:14 UTC 2011
Dne 10.1.2011 21:56, Jonathan Brassow napsal(a):
> Patch name: lvm-cleanup-1.patch
>
> lvcreate() does a 'memset(&lp, 0, sizeof(lp))', which is done by very
> next function called. No need to do it twice.
>
> Index: LVM2/tools/lvcreate.c
> ===================================================================
> --- LVM2.orig/tools/lvcreate.c
> +++ LVM2/tools/lvcreate.c
> @@ -538,8 +538,6 @@ int lvcreate(struct cmd_context *cmd, in
> struct lvcreate_cmdline_params lcp;
> struct volume_group *vg;
>
> - memset(&lp, 0, sizeof(lp));
> -
> if (!_lvcreate_params(&lp, &lcp, cmd, argc, argv))
> return EINVALID_CMD_LINE;
Ack
Valid and we already do the same with lcp.
Zdenek
More information about the lvm-devel
mailing list