[lvm-devel] [PATCH 2/2] Do not send random bytes in message
Alasdair G Kergon
agk at redhat.com
Fri Mar 4 20:42:33 UTC 2011
On Wed, Mar 02, 2011 at 07:09:08PM +0100, Zdenek Kabelac wrote:
> struct clvm_header contains 'char args[1]' - so adding '+ 1' here
> for the message length calculation is not correct - we end up with longer
> message where last byte is uninitialized and passed to write function.
What are the implications beyond the immediate line of code changed?
> xid and clintid are initialized to 0.
What are the implications of not setting these to 0?
Alasdair
More information about the lvm-devel
mailing list