[lvm-devel] [PATCH 3/4] Use allog_vg for _free_vg in _pvsegs_sub_single
Alasdair G Kergon
agk at redhat.com
Tue Mar 8 17:09:31 UTC 2011
On Wed, Mar 02, 2011 at 07:20:25PM +0100, Zdenek Kabelac wrote:
> Switch to use alloc_vg function for allocation of VG struct.
This code looks wrong. Maybe it suffered from some previous global change.
> - struct volume_group _free_vg = {
> - .cmd = cmd,
> - .name = "",
> - };
I think that should stay as it is.
> - if (!(_free_vg.vgmem = dm_pool_create("_free_vg", 10240)))
> - return ECMD_FAILED;
Why is vgmem being allocated? If something really is using it, why?
Alasdair
More information about the lvm-devel
mailing list