[lvm-devel] [PATCH 1/6] Unreleased pool is INTERNAL_ERROR

Zdenek Kabelac zkabelac at redhat.com
Mon Mar 28 11:59:12 UTC 2011


It's better for catching bugs in test-suite.
(As currently one test does not pass without noticing.)

Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
---
 libdm/mm/pool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libdm/mm/pool.c b/libdm/mm/pool.c
index 825f7ca..0e2444d 100644
--- a/libdm/mm/pool.c
+++ b/libdm/mm/pool.c
@@ -64,7 +64,6 @@ void dm_pools_check_leaks(void)
 	if (dm_list_empty(&_dm_pools))
 		return;
 
-	log_error("You have a memory leak (not released memory pool):");
 	dm_list_iterate_items(p, &_dm_pools) {
 #ifdef DEBUG_POOL
 		log_error(" [%p] %s (%u bytes)",
@@ -74,4 +73,5 @@ void dm_pools_check_leaks(void)
 		log_error(" [%p] %s", p, p->name);
 #endif
 	}
+	log_error(INTERNAL_ERROR "Unreleased memory pool(s) found.");
 }
-- 
1.7.4.1




More information about the lvm-devel mailing list