[lvm-devel] LVM2 tools/lvmcmdline.c liblvm/lvm_base.c lib/ ...

[Petr Rockai]

Hi,

Alasdair G Kergon <agk at redhat.com> writes:
> On Sat, May 07, 2011 at 01:50:19PM -0000, mornfall at sourceware.org wrote:
>> +	/* Set in/out stream buffering before glibc */
>
> Please add more explanatory comments inline.
>
> I mentioned this on IRC but there's been a trend towards not giving
> explanations inline which I'd like to see reversed.  Patch headers
> are becoming too long, containing information about the new version
> of the code which should instead have been placed inline.

I'd delegate this,

>> +  Avoid memlock size mismatch by preallocating stdio line buffers.

> If it fixed this, can't the temporary warning message suppression be
> removed now?

and this to Zdeněk, since he's the author of the patch in question and
might therefore be better qualified to answer. Zdeněk, if you'd prefer
to not deal with those, just bounce it back to me.

Yours,
   Petr

-- 
id' Ash = Ash; id' Dust = Dust; id' _ = undefined