[lvm-devel] [PATCH 3/3] Change default prefix.

Milan Broz mbroz at redhat.com
Wed Oct 26 11:19:37 UTC 2011


On 10/06/2011 11:43 AM, Zdenek Kabelac wrote:
> Use ""  instead of "  ".
> So commands like lvs print from the begining of the line.
> (no need to trim space around).
> 
> Signed-off-by: Zdenek Kabelac <zkabelac at redhat.com>
> ---
>  doc/example.conf.in   |    6 +++---
>  lib/config/defaults.h |    6 +++++-
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/doc/example.conf.in b/doc/example.conf.in
> index d38f90e..58748cc 100644
> --- a/doc/example.conf.in
> +++ b/doc/example.conf.in
> @@ -248,9 +248,9 @@ log {
>      command_names = 0
>  
>      # A prefix to use before the message text (but after the command name,
> -    # if selected).  Default is two spaces, so you can see/grep the severity
> -    # of each message.
> -    prefix = "  "
> +    # if selected). Set to "  " to revert to the default behaviour
> +    # prior to version 2.02.89.
> +    prefix = ""

I am not sure here...

IMHO lvs/pvs etc should not use prefix if there is --noheading, --separator
and such script options.

But do we really want to change default output?

Except this default prefix change, ack.

Milan




More information about the lvm-devel mailing list