[lvm-devel] [PATCH 8/7][retry remove] Also add check for filesystem use on a DM/LVM device - "dm_device_has_fs"

Milan Broz mbroz at redhat.com
Wed Sep 21 08:55:41 UTC 2011


On 09/20/2011 10:01 PM, Zdenek Kabelac wrote:
> How bad would be to replace the code in lvremove with something like:
> when remove fails -  call  system("udevadm settle") - and retry whole
> lv_remove_with_depenencies() (or whatever baselevel we pick here).

This solution was nacked already, please do not reiterate it again.

Avoid system() in any case, whatever command it is.

> PS: easiest workaround for failing lvremove is - to replace  lvremove with
> shell wrapper which call udevadm settle and retries lvremove in case the first
> one fails.

Yes, and all system security audit log will point to lvm. Please do not do
such home made solutions. This need proper solution and no such things.

Milan




More information about the lvm-devel mailing list