[lvm-devel] [RFC PATCH 0/3] optimize detection of MD devices
Dongsu Park
dongsu.park at profitbricks.com
Tue Jul 17 15:19:08 UTC 2012
Hi Alasdair,
On 16.07.2012 23:17, Alasdair G Kergon wrote:
> On Mon, Jul 16, 2012 at 11:18:36PM +0200, dongsu.park at profitbricks.com wrote:
> > This patchset optimizes the detection mechanism of MD devices, as well
>
> Optimising the detection, good.
Thank you for reviewing the patches.
> > as introduces a possibility to turn off detections of the legacy
> > metadata versions.
>
> Maybe, but I'd discourage people from turning it off more strongly, as it's a
> small price to pay for peace of mind.
>
> So, after review and a bit of tweaking, yes, I'm in favour.
>
> However, the whole of this code is itself 'legacy' in that this detection is
> moving into blkid under udev's control, so you should check if that code is
> sufficiently efficient too.
Ok, that's a good point.
It would be more optimal to get MD metadata versions, rather than to turn
off v1.0/v0.9 completely.
I think it could be possible to determine the MD metadata version of a
device, simply reading the sysfs attribute,
e.g. /sys/block/md*/md/metadata_version.
I'll post a second patchset with the improvement.
Dongsu
>
> Alasdair
>
More information about the lvm-devel
mailing list