[lvm-devel] master - lvmetad: empty types string is ok

Zdenek Kabelac zkabelac at fedoraproject.org
Mon Oct 15 09:03:38 UTC 2012


Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=3ed2c32e0a8f36c6d5da347b5367aa16d52245aa
Commit:        3ed2c32e0a8f36c6d5da347b5367aa16d52245aa
Parent:        a0e60d27ff91c46a1febf58a955c6b88539ba982
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Mon Oct 15 11:02:15 2012 +0200
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Mon Oct 15 11:02:15 2012 +0200

lvmetad: empty types string is ok

Since now return code is test - return OK for this case.
---
 libdaemon/server/daemon-log.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/libdaemon/server/daemon-log.c b/libdaemon/server/daemon-log.c
index 1e1c9e0..6f5f4dc 100644
--- a/libdaemon/server/daemon-log.c
+++ b/libdaemon/server/daemon-log.c
@@ -153,12 +153,16 @@ static int _parse_one(log_state *s, int outlet, const char *type, int enable)
 
 int daemon_log_parse(log_state *s, int outlet, const char *types, int enable)
 {
-	char *buf = dm_strdup(types);
-	char *pos = buf;
+	char *buf;
+	char *pos;
 
-	if (!buf)
+	if (!types || !types[0])
+		return 1;
+
+	if (!(buf = dm_strdup(types)))
 		return 0;
 
+	pos = buf;
 	while (pos) {
 		char *next = strchr(pos, ',');
 		if (next)




More information about the lvm-devel mailing list