[lvm-devel] [PATCH] Fix return value of persistent_filters_dump if rename failed
Nir Soffer
nsoffer at redhat.com
Thu Oct 17 19:25:58 UTC 2013
>From eeae04cf523e0c3050d5c686b29fb53316d3c760 Mon Sep 17 00:00:00 2001
From: Nir Soffer <nsoffer at redhat.com>
Date: Thu, 17 Oct 2013 21:18:06 +0300
Subject: [PATCH] Fix return value of persistent_filters_dump if rename failed
---
lib/filters/filter-persistent.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/filters/filter-persistent.c b/lib/filters/filter-persistent.c
index 14a3480..f068369 100644
--- a/lib/filters/filter-persistent.c
+++ b/lib/filters/filter-persistent.c
@@ -253,9 +253,11 @@ static int _persistent_filter_dump(struct dev_filter *f, int merge_existing)
if (lvm_fclose(fp, tmp_file))
goto_out;
- if (rename(tmp_file, pf->file))
+ if (rename(tmp_file, pf->file)) {
log_error("%s: rename to %s failed: %s", tmp_file, pf->file,
strerror(errno));
+ goto out;
+ }
r = 1;
--
1.8.3.1
More information about the lvm-devel
mailing list