[lvm-devel] master - cleanup: dmeventd simplify status processing
Zdenek Kabelac
zkabelac at fedoraproject.org
Fri Apr 18 14:55:33 UTC 2014
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=13d05211d006a63035afea44fa8a4b1222130cd5
Commit: 13d05211d006a63035afea44fa8a4b1222130cd5
Parent: 4fb588c34ee9b64333ad39ab039d657cf6e958ab
Author: Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate: Fri Apr 18 13:34:44 2014 +0200
Committer: Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Fri Apr 18 16:38:52 2014 +0200
cleanup: dmeventd simplify status processing
Since we always know the string length, use simplier memcpy.
---
daemons/dmeventd/dmeventd.c | 25 ++++++++++++-------------
1 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/daemons/dmeventd/dmeventd.c b/daemons/dmeventd/dmeventd.c
index a907ca6..81da166 100644
--- a/daemons/dmeventd/dmeventd.c
+++ b/daemons/dmeventd/dmeventd.c
@@ -473,25 +473,24 @@ static int _get_status(struct message_data *message_data)
_unlock_mutex();
goto out;
}
- ++ i;
- size += current;
+ ++i;
+ size += current; /* count with trailing '\0' */
}
_unlock_mutex();
- msg->size = size + strlen(message_data->id) + 1;
- msg->data = dm_malloc(msg->size);
- if (!msg->data)
+ len = strlen(message_data->id);
+ msg->size = size + len + 1;
+ dm_free(msg->data);
+ if (!(msg->data = dm_malloc(msg->size)))
goto out;
- *msg->data = 0;
- message = msg->data;
- strcpy(message, message_data->id);
- message += strlen(message_data->id);
- *message = ' ';
- message ++;
+ memcpy(msg->data, message_data->id, len);
+ message = msg->data + len;
+ *message++ = ' ';
for (j = 0; j < i; ++j) {
- strcpy(message, buffers[j]);
- message += strlen(buffers[j]);
+ len = strlen(buffers[j]);
+ memcpy(message, buffers[j], len);
+ message += len;
}
ret = 0;
More information about the lvm-devel
mailing list