[lvm-devel] master - libdm: check version prints error

Zdenek Kabelac zkabelac at fedoraproject.org
Tue Aug 19 14:18:53 UTC 2014


Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=10e2370d2efc501067702ffd5cd86940c3637e1c
Commit:        10e2370d2efc501067702ffd5cd86940c3637e1c
Parent:        dec39b1a5f0f599fd751bc6cea8caaac8a211d31
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Tue Aug 19 14:22:22 2014 +0200
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Tue Aug 19 14:33:06 2014 +0200

libdm: check version prints error

Move 'bad' label above log_error, so the
error message is printed on 'bad' path.
(And return 0 is not without log_error()).
---
 libdm/ioctl/libdm-iface.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libdm/ioctl/libdm-iface.c b/libdm/ioctl/libdm-iface.c
index 4f55ddf..7d50f3a 100644
--- a/libdm/ioctl/libdm-iface.c
+++ b/libdm/ioctl/libdm-iface.c
@@ -544,10 +544,10 @@ int dm_check_version(void)
 
 	dm_get_library_version(libversion, sizeof(libversion));
 
+      bad:
 	log_error("Incompatible libdevmapper %s%s and kernel driver %s",
 		  libversion, compat, dmversion);
 
-      bad:
 	_version_ok = 0;
 	return 0;
 }




More information about the lvm-devel mailing list