[lvm-devel] master - tests: fix volume list test

Zdenek Kabelac zkabelac at fedoraproject.org
Tue Aug 26 12:17:43 UTC 2014


Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=c37ca279e33b532f00da4b2f50e8e1ad547e8a77
Commit:        c37ca279e33b532f00da4b2f50e8e1ad547e8a77
Parent:        25fe716b123109dee83a593d3c354ffac13b06b1
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Tue Aug 26 12:09:03 2014 +0200
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Tue Aug 26 14:13:07 2014 +0200

tests: fix volume list test

Proper use of \" escaping and shell vars.
---
 test/shell/lvchange-thin.sh |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/test/shell/lvchange-thin.sh b/test/shell/lvchange-thin.sh
index cb9be53..4d33563 100644
--- a/test/shell/lvchange-thin.sh
+++ b/test/shell/lvchange-thin.sh
@@ -99,7 +99,7 @@ not lvchange --resync --addtag foo $vg/$lv1
 # Play with tags and activation
 #
 TAG=$(uname -n)
-aux lvmconf 'activation/volume_list = [ "$vg/$lv2", "@mytag", "$vg2" ]'
+aux lvmconf "activation/volume_list = [ \"$vg/$lv2\", \"@mytag\" ]"
 
 lvchange -ay $vg/$lv1
 check inactive $vg $lv1
@@ -123,9 +123,11 @@ not lvcreate -Zy -L10 -n $lv3 $vg2
 lvcreate -Zn -L10 -n $lv3 $vg2
 check inactive $vg2 $lv3
 
-aux lvmconf 'activation/volume_list = [ "$vg2" ]'
+aux lvmconf "activation/volume_list = [ \"$vg2\" ]"
 vgchange -an $vg
 vgchange -ay $vg $vg2
 lvs -a -o+lv_active $vg $vg2
 
+aux lvmconf "activation/volume_list = [ \"$vg\", \"$vg2\" ]"
+
 vgremove -ff $vg $vg2




More information about the lvm-devel mailing list