[lvm-devel] [PATCH] pvchange: use process_each_pv

[Zdenek Kabelac]

Dne 16.10.2014 v 23:41 David Teigland napsal(a):
> The summary output at the end has been removed.
> A similar counter method could be added to the
> various process_each functions if we want to
> retain this sort of summary reporting.
>
> ---
>   tools/pvchange.c | 112 +++++++++++--------------------------------------------
>   1 file changed, 22 insertions(+), 90 deletions(-)
>
> diff --git a/tools/pvchange.c b/tools/pvchange.c
> index c2adc34309c5..e10da609f3c5 100644
> --- a/tools/pvchange.c
> +++ b/tools/pvchange.c
> @@ -40,20 +40,20 @@ static int _pvchange_single(struct cmd_context *cmd, struct volume_group *vg,
>   		if (tagargs && !(vg->fid->fmt->features & FMT_TAGS)) {
>   			log_error("Volume group containing %s does not "
>   				  "support tags", pv_name);
> -			return 0;
> +			return ECMD_FAILED;
>   		}


I'd prefer to not switch internal functions that are called after the VG is 
opened to anything else then 0/1 return code.

Logic is:


When command starts - it validates options - any error detected before the VG 
is opened means  EINVALID_CMD_LINE == 3 return code (but if the error is 
result of i.e. failing memory alloc it should be ECMD_FAIL)

Once you open VG - error is always ECMD_FAIL since VG was needed to resolve 
it. We do not make any more differences on cmd return code - more info goes 
from error message.

So until we figure out reasonable good interface for error passing form 
library function for error reporting I'd keep any function to stay with
0 - error
1 - ok

Once we start mixing ECMD_PROCESSED == 0  with 0/1 functions
we get into troubles  (I've already fixing these errors).

Zdenek