[lvm-devel] [PATCH] lvconvert: limit lv types for cache use

[Peter Rajnoha]

On 09/03/2014 11:14 AM, Zdenek Kabelac wrote:
> Dne 2.9.2014 v 22:56 David Teigland napsal(a):
>> +static const char *lv_is_name(struct logical_volume *lv)
>> +{
>> +    if (lv_is_external_origin(lv))
>> +        return "external_origin";
>> +
> 
> There is already a reporting function for this with new Petr's patches.
> 
> 

That's the lv_layout_and_role fn. However, this one produces two lists
of strings, not single concatenated string (for both "layout" and "role").
It was designed for reporting lv_layout and lv_role fields originally.
So this would need to be patched a little bit to produce a single string
that is suitable for issuing messages.

But yes, to keep the consistency here, the same identification should be
used for messages too. I'll add a patch for that.

-- 
Peter