[lvm-devel] [PATCH 1/1] cmirrord:fix endian issue on s390
Brassow Jonathan
jbrassow at redhat.com
Mon Sep 8 17:54:51 UTC 2014
Yes, this is the sort of patch I'm looking for. Can you confirm it works for s390 and x86[_64]? That patch looks good to me otherwise.
brassow
On Sep 4, 2014, at 11:32 PM, Liuhua Wang wrote:
> Cmirrord has endian bugs, which cause failure to lvcreate a mirrored lv on s390.
> - data_size is uint32, should not use xlate64 to convert, which will cause data_size 0
> after xlate.
> - request_type and data_size still used by local(v5_data_switch), should convert later.
> if request_type xlate too early, it will cause request_type judge error;
> if data_size xlate too early, it will cause coredump in case DM_ULOG_CLEAR_REGION.
> - when receiving package in clog_request_from_network. vp[0] will always be little endian.
> we could use xlate64(vp[0]) == vp[0] to decide if the local node is little endian or not.
>
> Signed-off-by: Lidong Zhong<lzhong at suse.com> & Liuhua Wang <lwang at suse.com>
>
> ---
> daemons/cmirrord/compat.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/daemons/cmirrord/compat.c b/daemons/cmirrord/compat.c
> index 3f7a9b5..4955f50 100644
> --- a/daemons/cmirrord/compat.c
> +++ b/daemons/cmirrord/compat.c
> @@ -126,13 +126,14 @@ static int v5_endian_to_network(struct clog_request *rq)
>
> u_rq->error = xlate32(u_rq->error);
> u_rq->seq = xlate32(u_rq->seq);
> - u_rq->request_type = xlate32(u_rq->request_type);
> - u_rq->data_size = xlate64(u_rq->data_size);
>
> rq->originator = xlate32(rq->originator);
>
> v5_data_endian_switch(rq, 1);
>
> + u_rq->request_type = xlate32(u_rq->request_type);
> + u_rq->data_size = xlate32(u_rq->data_size);
> +
> return size;
> }
>
> @@ -167,7 +168,7 @@ static int v5_endian_from_network(struct clog_request *rq)
> u_rq->error = xlate32(u_rq->error);
> u_rq->seq = xlate32(u_rq->seq);
> u_rq->request_type = xlate32(u_rq->request_type);
> - u_rq->data_size = xlate64(u_rq->data_size);
> + u_rq->data_size = xlate32(u_rq->data_size);
>
> rq->originator = xlate32(rq->originator);
>
> @@ -187,7 +188,7 @@ int clog_request_from_network(void *data, size_t data_len)
>
> switch (version) {
> case 5: /* Upstream */
> - if (version == unconverted_version)
> + if (version == vp[0])
> return 0;
> break;
> case 4: /* RHEL 5.[45] */
> --
> 1.9.0
>
> --
> lvm-devel mailing list
> lvm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/lvm-devel
More information about the lvm-devel
mailing list