[lvm-devel] [PATCH] lvmdiskscan: improve the output of this command

Alasdair G Kergon agk at redhat.com
Wed Dec 2 19:18:32 UTC 2015


On Wed, Dec 02, 2015 at 05:10:22PM +0800, Lidong Zhong wrote:
>  		log_print("%d disk%s",
> -			  disks_found, disks_found == 1 ? "" : "s");
> +			  disks_found, disks_found <= 1 ? "" : "s");

"No disks" is best. "0 disks" is a lazy alternative.
"No disk" is also OK, but "0 disk" is wrong.

Alasdair




More information about the lvm-devel mailing list