[lvm-devel] master - clvmd: Fix freeze if client dies holding locks.

Ferenc Wagner wferi at niif.hu
Mon Jul 27 14:45:18 UTC 2015


Alasdair Kergon <agk at fedoraproject.org> writes:

> +		if (max_fd > FD_SETSIZE - 32) {
> +			fprintf(stderr, "WARNING: There are too many connections to clvmd.  Investigate and take action now!\n");
> + 			fprintf(stderr, "WARNING: Your cluster may freeze up if the number of clvmd file descriptors (%d) exceeds %d.\n", max_fd + 1, FD_SETSIZE);
> +		}

Just an outsider question: why do you use stderr here instead of some
generic logging function?  If clvmd is run as a daemon, stderr is
/dev/null, thus these messages are lost.
-- 
Thanks,
Feri.




More information about the lvm-devel mailing list