[lvm-devel] master - format_text: Fix precommitted segfault.

Alasdair Kergon agk at fedoraproject.org
Thu Mar 19 11:17:13 UTC 2015


Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=a515a91fcc8df04b5dfd9fe23ef6925c58846af0
Commit:        a515a91fcc8df04b5dfd9fe23ef6925c58846af0
Parent:        e4fa7563853a0f104dec0872760d4acfa08d2554
Author:        Alasdair G Kergon <agk at redhat.com>
AuthorDate:    Thu Mar 19 11:14:47 2015 +0000
Committer:     Alasdair G Kergon <agk at redhat.com>
CommitterDate: Thu Mar 19 11:14:47 2015 +0000

format_text: Fix precommitted segfault.

The code never mixes reads of committed and precommitted metadata,
so there's no need to attempt to set PRECOMMITTED when
*use_previous_vg is being set.
---
 lib/format_text/format-text.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/format_text/format-text.c b/lib/format_text/format-text.c
index 6b09d00..bdac7f9 100644
--- a/lib/format_text/format-text.c
+++ b/lib/format_text/format-text.c
@@ -551,7 +551,7 @@ static struct volume_group *_vg_read_raw_area(struct format_instance *fid,
 				   dev_name(area->dev),
 				   area->start + rlocn->offset, rlocn->size);
 
-	if (precommitted)
+	if (vg && precommitted)
 		vg->status |= PRECOMMITTED;
 
       out:




More information about the lvm-devel mailing list