[lvm-devel] [PATCH 3/4] dmeventd: Remove an useless _lock_mutex

[Marian Csontos]

One of the branches was locking a mutex only to unlock it later.
---
This may be more esthetic than performance issue.

Definitely trading a little performance gain for clarity.

 daemons/dmeventd/dmeventd.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/daemons/dmeventd/dmeventd.c b/daemons/dmeventd/dmeventd.c
index ff11625..82c8cc3 100644
--- a/daemons/dmeventd/dmeventd.c
+++ b/daemons/dmeventd/dmeventd.c
@@ -1088,6 +1088,7 @@ static int _register_for_event(struct message_data *message_data)
 		}
 
 		LINK_THREAD(thread);
+		_unlock_mutex();
 	} else {
 		/* Or event # into events bitfield. */
 		orig_events = thread->events;
@@ -1100,13 +1101,12 @@ static int _register_for_event(struct message_data *message_data)
 				 * consistency. */
 				_lock_mutex();
 				thread->events &= ~DM_EVENT_TIMEOUT;
-			} else
-				_lock_mutex();
-		}
+				_unlock_mutex();
+			}
+		} else
+			_unlock_mutex();
 	}
 
-	_unlock_mutex();
-
       out:
 	/*
 	 * Deallocate thread status after releasing
-- 
1.8.3.1