[lvm-devel] master - lvconvert: Improve error message when no -m.

[Alasdair Kergon]

Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=5c3141a8b9f2a4d67ca50674bc1bfec20fdc9e09
Commit:        5c3141a8b9f2a4d67ca50674bc1bfec20fdc9e09
Parent:        be497175e03b5cb51f2972a84528216bba06412a
Author:        Alasdair G Kergon <agk at redhat.com>
AuthorDate:    Wed Aug 3 23:31:50 2016 +0100
Committer:     Alasdair G Kergon <agk at redhat.com>
CommitterDate: Wed Aug 3 23:43:59 2016 +0100

lvconvert: Improve error message when no -m.

---
 tools/lvconvert.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index b365049..0aac89e 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -1853,7 +1853,12 @@ static int _lvconvert_raid(struct logical_volume *lv, struct lvconvert_params *l
 	}
 
 	if (seg_is_linear(seg) && !lp->merge_mirror && !lp->mirrors_supplied) {
-		log_error("Raid conversions require -m/--mirrors.");
+		if (_raid0_type_requested(lp->type_str))
+			log_error("Linear LV %s cannot be converted to %s.",
+				  display_lvname(lv), lp->type_str);
+		else
+			log_error("Raid conversions of LV %s require -m/--mirrors.",
+				  display_lvname(lv));
 		goto try_new_takeover_or_reshape;
 	}