[lvm-devel] master - coverity: close socket before closing app
Zdenek Kabelac
zkabelac at fedoraproject.org
Fri Jul 15 13:49:34 UTC 2016
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=4de7a843ebc5c9ed4c54225a1a062cf40534edaf
Commit: 4de7a843ebc5c9ed4c54225a1a062cf40534edaf
Parent: d2bb19e883f46a95e9780cea046e6e0a5db006b9
Author: Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate: Fri Jul 15 15:42:01 2016 +0200
Committer: Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Fri Jul 15 15:49:01 2016 +0200
coverity: close socket before closing app
Opened socket descriptor goes out-of-sight still opened.
Close it - but since this happens before app exit, it
just fixed valgrind report.
---
libdaemon/server/daemon-server.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/libdaemon/server/daemon-server.c b/libdaemon/server/daemon-server.c
index 7911dd6..e4d7ce2 100644
--- a/libdaemon/server/daemon-server.c
+++ b/libdaemon/server/daemon-server.c
@@ -660,6 +660,10 @@ out:
if (unlink(s.socket_path))
perror("unlink error");
+ if (s.socket_fd >= 0)
+ if (close(s.socket_fd))
+ perror("scoket close");
+
if (s.daemon_fini)
if (!s.daemon_fini(&s))
failed = 1;
More information about the lvm-devel
mailing list