[lvm-devel] master - vgcreate: check vg_name and PV arguments

[Bryn Reeves]

Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=a81c1749923ba8861f1af91be61765f0599bf61c
Commit:        a81c1749923ba8861f1af91be61765f0599bf61c
Parent:        259f9dd71817ad33195384dbeca14b39dfb77ae1
Author:        Bryn M. Reeves <bmr at redhat.com>
AuthorDate:    Thu Jul 21 17:28:26 2016 +0100
Committer:     Bryn M. Reeves <bmr at redhat.com>
CommitterDate: Thu Jul 21 17:28:26 2016 +0100

vgcreate: check vg_name and PV arguments

---
 tools/vgcreate.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/tools/vgcreate.c b/tools/vgcreate.c
index af0c363..85b0b82 100644
--- a/tools/vgcreate.c
+++ b/tools/vgcreate.c
@@ -38,6 +38,18 @@ int vgcreate(struct cmd_context *cmd, int argc, char **argv)
 	argc--;
 	argv++;
 
+	if (strchr(vg_name, '/')) {
+		log_error("Volume group name expected before physical volume "
+			  "arguments");
+		return EINVALID_CMD_LINE;
+	}
+
+	if (!argc) {
+		log_error("Please provide physical volumes for new volume "
+			  "group %s", vg_name);
+		return EINVALID_CMD_LINE;
+	}
+
 	pvcreate_params_set_defaults(&pp);
 
 	if (!pvcreate_params_from_args(cmd, &pp))