[lvm-devel] master - lvmdbustest: Comment out refresh check for LV create

tasleson tasleson at fedoraproject.org
Tue Jun 28 19:24:43 UTC 2016


Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=6f216692b47b38f480e50d213de5c513a309d9e0
Commit:        6f216692b47b38f480e50d213de5c513a309d9e0
Parent:        1d3532d0a7d458550b53218a6b21798eab30b68e
Author:        Tony Asleson <tasleson at redhat.com>
AuthorDate:    Tue Jun 28 13:36:32 2016 -0500
Committer:     Tony Asleson <tasleson at redhat.com>
CommitterDate: Tue Jun 28 13:36:32 2016 -0500

lvmdbustest: Comment out refresh check for LV create

When we test Vg.LvCreateRaid some of the hidden LVs volume type go from
'I' to 'i' between the time it takes us to create the LV and
the time it takes to call into refresh to verify the service is up to date.
This is a fairly rare occurance.
---
 test/dbus/lvmdbustest.py |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/test/dbus/lvmdbustest.py b/test/dbus/lvmdbustest.py
index 4443b0c..457db96 100755
--- a/test/dbus/lvmdbustest.py
+++ b/test/dbus/lvmdbustest.py
@@ -373,7 +373,11 @@ class TestDbusService(unittest.TestCase):
 			lv = ClientProxy(self.bus, path)
 			# TODO verify object properties
 
-		self.assertEqual(self._refresh(), 0)
+		# We are quick enough now that we can get VolumeType changes from
+		# 'I' to 'i' between the time it takes to create a RAID and it returns
+		# and when we refresh state here.  Not sure how we can handle this as
+		# we cannot just sit and poll all the time for changes...
+		# self.assertEqual(self._refresh(), 0)
 		return lv
 
 	def test_lv_create(self):




More information about the lvm-devel mailing list