[lvm-devel] [PATCH 0/1] adding Btrfs resizing capability to lvresize/fsadm.sh

[Eric Ren]

Hi Zdenek and Marcus,

On 08/14/2017 08:50 PM, Zdenek Kabelac wrote:
> [...snip...]
>
> Hi
>
> From my memory - when we tried to use such patch in past - we've found 
> too many rough edges on anything  btrfs related.
>
> I'm not an expert of btrfs at all - but we noticed lot of troubles in 
> terms
> of  btrfs was not even noticing it has got smaller, disk got missing
> and many other conditions.
>
> So to get such  'btrfs resize' patch accepted - it MUST be equipped with
> lvm2 test suite script - possibly with a new separate test file
> (so it's not mixed with already complex test/shell/fsadm.sh)
>
> It should test fair amount of condition - so we can be at least partially
> sure  'fsadm' will not totally mess users data just because it has run
> command on some unexpected variants of 'btrfs' disk layout.
>
> In fact it should check for 'known layout' and only let proceed with
> command on this path   (including for checking minimal version
> of kernel and btrfs-tools where btrfs is known to be stable enough for 
> this operation.
>
>
> I do believe that format of /test/shell/*sh is relatively readable.
> For running the test -
>
> do your lvm2 build and then within subdir /test/  run something like:
>
> 'make check_local T=fsadm-btrfs.sh VERBOSE=1'
>
> to check the tool is doing something useful.
> If something is unclear - feel free to reach me on freenode #lvm channel
> to get this working properly.

Thanks for your detailed feedback!

I can try to write such a testcase, and ask you
for review when it's finished ;-)

Cheers,
Eric
>
> Regards
>
> Zdenek
>