[lvm-devel] 答复: Re: [PATCH 1/1] added resizing for btrfs

Eric Ren zren at suse.com
Fri Aug 25 09:44:47 UTC 2017


Hi Marcus,


On 08/24/2017 08:49 PM, Marcus Müller wrote:
> [...snip...]
>
> I'm certainly not one to withhold a revised patch, but: If Lidong 
> Zhong (hi!) got his patch reviewed already from btrfs folks – I might 
> personally prefer that
>
> For example, the mount point detection based on the external `findmnt` 
> program (didn't know that existed) looks more robust, and precautions 
> that I didn't take (like setting LC_ALL for calling `btrfs`) indicate 
> that the best-case modification of my patch would actually be his 
> patch. I haven't thought of it this way so far.
>
> Do you still want me to modify my patch?

I noticed that Lidong has posted his patch for you reference. So, feel 
free to take good points from his patch
into your v2 patch. Perhaps, you may give him credits by add 
"signed-off-by" in the patch header along with yours.

Thanks,
Eric




More information about the lvm-devel mailing list