[lvm-devel] master - thin: missing type is error

Zdenek Kabelac zkabelac at sourceware.org
Thu Dec 7 20:03:36 UTC 2017


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=c3e224ad0ebd473268b171204c8985c9c642f590
Commit:        c3e224ad0ebd473268b171204c8985c9c642f590
Parent:        2208ebfe16e5b5cd54c762a5a06edd0681d62fa9
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Wed Dec 6 13:21:01 2017 +0100
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Thu Dec 7 20:59:37 2017 +0100

thin: missing type is error

---
 libdm/libdm-deptree.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libdm/libdm-deptree.c b/libdm/libdm-deptree.c
index b844a57..1ef1700 100644
--- a/libdm/libdm-deptree.c
+++ b/libdm/libdm-deptree.c
@@ -1394,9 +1394,9 @@ static int _thin_pool_get_status(struct dm_tree_node *dnode,
 
 	dm_get_next_target(dmt, NULL, &start, &length, &type, &params);
 
-	if (type && (strcmp(type, "thin-pool") != 0)) {
+	if (!type || (strcmp(type, "thin-pool") != 0)) {
 		log_error("Expected thin-pool target for %s and got %s.",
-			  _node_name(dnode), type);
+			  _node_name(dnode), type ? : "no target");
 		goto out;
 	}
 




More information about the lvm-devel mailing list