[lvm-devel] master - device: Internal error if writing 0 bytes to dev.

Alasdair Kergon agk at sourceware.org
Tue Dec 12 12:59:38 UTC 2017


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=c5ef76bf27337406d48990acbfdaa869fd30f47b
Commit:        c5ef76bf27337406d48990acbfdaa869fd30f47b
Parent:        7272fd221096dbfd07e7ad11f0c938b453de2904
Author:        Alasdair G Kergon <agk at redhat.com>
AuthorDate:    Tue Dec 12 12:57:25 2017 +0000
Committer:     Alasdair G Kergon <agk at redhat.com>
CommitterDate: Tue Dec 12 12:57:25 2017 +0000

device: Internal error if writing 0 bytes to dev.

---
 lib/device/dev-io.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/lib/device/dev-io.c b/lib/device/dev-io.c
index a9a9aac..dc9ad13 100644
--- a/lib/device/dev-io.c
+++ b/lib/device/dev-io.c
@@ -804,6 +804,11 @@ int dev_write(struct device *dev, uint64_t offset, size_t len, dev_io_reason_t r
 	if (!_dev_is_valid(dev))
 		return 0;
 
+	if (!len) {
+		log_error(INTERNAL_ERROR "Attempted to write 0 bytes to %s at " FMTu64, dev_name(dev), offset);
+		return 0;
+	}
+
 	where.dev = dev;
 	where.start = offset;
 	where.size = len;




More information about the lvm-devel mailing list