[lvm-devel] master - cleanup: rename internal define

[Zdenek Kabelac]

Dne 9.6.2017 v 13:48 Marian Csontos napsal(a):
> On 06/08/2017 12:03 PM, Zdenek Kabelac wrote:
>> Gitweb:        
>> https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=719d0996930dfad8608c49af2f81008b6ca77cb8 
>>
>> Commit:        719d0996930dfad8608c49af2f81008b6ca77cb8
>> Parent:        39703cb48514415633bc027e49e99e1ee7c4bbb4
>> Author:        Zdenek Kabelac <zkabelac at redhat.com>
>> AuthorDate:    Fri Jun 2 11:18:04 2017 +0200
>> Committer:     Zdenek Kabelac <zkabelac at redhat.com>
>> CommitterDate: Thu Jun 8 11:07:18 2017 +0200
>>
>> cleanup: rename internal define
>>
>> More descriptive name of #define.
>> ---
>>   lib/config/defaults.h     |    2 +-
>>   lib/metadata/thin_manip.c |    2 +-
>>   liblvm/lvm_lv.c           |    2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/config/defaults.h b/lib/config/defaults.h
>> index 65b81f1..05747fa 100644
>> --- a/lib/config/defaults.h
>> +++ b/lib/config/defaults.h
>> @@ -106,7 +106,7 @@
>>   #define DEFAULT_THIN_POOL_METADATA_REQUIRE_SEPARATE_PVS 0
>>   #define DEFAULT_THIN_POOL_MAX_METADATA_SIZE (16 * 1024 * 1024)  /* KB */
>>   #define DEFAULT_THIN_POOL_MIN_METADATA_SIZE 2048  /* KB */
>> -#define DEFAULT_THIN_POOL_OPTIMAL_SIZE     (128 * 1024 * 1024)    /* KB */
>> +#define DEFAULT_THIN_POOL_OPTIMAL_METADATA_SIZE (128 * 1024 * 1024) /* KB */
> 
> Inconsistency here:
> 
> Should this be B instead of KB?
> 
> Or 128 * 1024 to make it consistent with the rest, and adjust calculations later?
> 

Hi

Thanks for noticing, you are possibly right - I should've also clean the 
numbers so we could drop sectorsize from calcs

I'll take a look.

Zdenek