[lvm-devel] master - debug: fail in backup is not traced nor error

Zdenek Kabelac zkabelac at sourceware.org
Mon Jun 26 22:29:47 UTC 2017


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=d444accdbfdda0712d4a83ac178378580d3f7714
Commit:        d444accdbfdda0712d4a83ac178378580d3f7714
Parent:        c3e0ef1a5eef973bb79c3f94653077cc87b250c0
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Mon Jun 26 23:27:10 2017 +0200
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Tue Jun 27 00:27:36 2017 +0200

debug: fail in backup is not traced nor error

---
 lib/metadata/raid_manip.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c
index 774924a..110a7d3 100644
--- a/lib/metadata/raid_manip.c
+++ b/lib/metadata/raid_manip.c
@@ -2147,8 +2147,8 @@ static int _vg_write_lv_suspend_commit_backup(struct volume_group *vg,
 	} else if (!(r = vg_commit(vg)))
 		stack; /* !vg_commit() has implicit vg_revert() */
 
-	if (r && do_backup && !backup(vg))
-		log_error("Backup of VG %s failed; continuing.", vg->name);
+	if (r && do_backup)
+		backup(vg);
 
 	return r;
 }




More information about the lvm-devel mailing list