[lvm-devel] master - libdm: fix endless loop

Zdenek Kabelac zkabelac at sourceware.org
Thu Mar 16 00:02:38 UTC 2017


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=42b970d4f34a0cf70ac07d551852cbd7b924079f
Commit:        42b970d4f34a0cf70ac07d551852cbd7b924079f
Parent:        2a139993b40c4497536a2a0b6d826c73213b332d
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Thu Mar 16 00:36:06 2017 +0100
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Thu Mar 16 01:02:10 2017 +0100

libdm: fix endless loop

Coverity noticed endless loop (i not being changed).

TODO: test coverage
---
 libdm/libdm-stats.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libdm/libdm-stats.c b/libdm/libdm-stats.c
index 559920e..e977f08 100644
--- a/libdm/libdm-stats.c
+++ b/libdm/libdm-stats.c
@@ -678,7 +678,7 @@ static void _check_group_regions_present(struct dm_stats *dms,
 
 	group_id = i = dm_bit_get_first(regions);
 
-	for (; i > 0; dm_bit_get_next(regions, i))
+	for (; i > 0; i = dm_bit_get_next(regions, i))
 		if (!_stats_region_present(&dms->regions[i])) {
 			log_warn("Group descriptor " FMTi64 " contains "
 				 "non-existent region_id " FMTi64 ".",




More information about the lvm-devel mailing list