[lvm-devel] [PATCH] lvconvert: fix wrong name order when merging thin snapshot

[Eric Ren]

Hi Zdenek,

>
> The only trouble here is that 'display_lvname()' is using internal 
> ring buffer inside cmd struct, so the output is meant to be used 
> immediately, otherwise
> it might get overwritten and you will get on output some garbage.
> So the proper solution here is to copy the string (dm_strncpy()) in
> a local buffer[NAME_LEN] buffer.

I considered fixing it in this way, but it seems using display_lvname() 
here is OK. I tested this patch,
which doesn't output garbage, and I see other places also do like this. 
So, I intended to save a
string copy.

> But I'll handle that one myself.
>
> Thanks for noticing.
No problem, but I'm thinking I can send patch v2 if it's a real problem...

Thanks,
Eric