[lvm-devel] master - pvmove: drop misleading pvmove restriction for cluster

Zdenek Kabelac zkabelac at sourceware.org
Wed Jan 17 13:46:33 UTC 2018


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=02621cffb0d5ff72adb8770e26c1b4adb95bd0d9
Commit:        02621cffb0d5ff72adb8770e26c1b4adb95bd0d9
Parent:        5a961d3411c8c11312d2998378277efc8988fc7f
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Thu Jan 11 16:15:16 2018 +0100
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Wed Jan 17 14:44:33 2018 +0100

pvmove: drop misleading pvmove restriction for cluster

pvmove handles properly locked LVs in cluster and this extra check
actually cause misbehavior as some LVs were silently skipped from
operation scope.
---
 tools/pvmove.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/tools/pvmove.c b/tools/pvmove.c
index 9bbe12b..c5d7e52 100644
--- a/tools/pvmove.c
+++ b/tools/pvmove.c
@@ -371,16 +371,6 @@ static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd,
 		if (lv_name && strcmp(lv->name, top_level_lv_name(vg, lv_name)))
 			continue;
 
-		/*
-		 * RAID, thin and snapshot-related LVs are not
-		 * processed in a cluster, so we don't have to
-		 * worry about avoiding certain PVs in that context.
-		 *
-		 * Allow clustered mirror, but not raid mirror.
-		 */
-		if (vg_is_clustered(vg) && !lv_is_mirror_type(lv))
-			continue;
-
 		if (!lv_is_on_pvs(lv, source_pvl))
 			continue;
 




More information about the lvm-devel mailing list