[lvm-devel] 2018-06-01-stable - vgchange: fix error code in error path

Zdenek Kabelac zkabelac at sourceware.org
Fri Jun 22 13:07:49 UTC 2018


Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=4479228d324fff4863a068ae02c775fd52fb58fb
Commit:        4479228d324fff4863a068ae02c775fd52fb58fb
Parent:        4afb5971b93af79f81dfb3fff33b25fec270ac37
Author:        Zdenek Kabelac <zkabelac at redhat.com>
AuthorDate:    Wed Jun 13 15:57:51 2018 +0200
Committer:     Zdenek Kabelac <zkabelac at redhat.com>
CommitterDate: Fri Jun 22 12:29:42 2018 +0200

vgchange: fix error code in error path

This rather hard to hit error path used wrong return value to signal
real error.
---
 tools/vgchange.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/vgchange.c b/tools/vgchange.c
index 531bedc..623517b 100644
--- a/tools/vgchange.c
+++ b/tools/vgchange.c
@@ -199,7 +199,7 @@ int vgchange_activate(struct cmd_context *cmd, struct volume_group *vg,
 	    strcmp(vg->system_id, cmd->system_id) &&
 	    do_activate) {
 		log_error("Cannot activate LVs in a foreign VG.");
-		return ECMD_FAILED;
+		return 0;
 	}
 
 	/*




More information about the lvm-devel mailing list